Skip to content

View rayclusters CLI changes #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2023
Merged

View rayclusters CLI changes #279

merged 4 commits into from
Aug 4, 2023

Conversation

carsonmh
Copy link
Contributor

@carsonmh carsonmh commented Aug 3, 2023

Issue link

implemented changes for #258

What changes have been made

  • Made functions use current namespace by default
  • List raycluster plural alias (user can use rayclusters or raycluster)
  • Refactor _get_all_rayclusters function

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@MichaelClifford
Copy link
Collaborator

Thanks for the additional changes @carsonmh This looks great! :)

@openshift-merge-robot openshift-merge-robot merged commit 18a2aa5 into project-codeflare:cli-update Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@anishasthana anishasthana Awaiting requested review from anishasthana

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@MichaelClifford MichaelClifford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonmh @MichaelClifford @openshift-merge-robot